Uh oh!
There was an error while loading. Please reload this page.
feat: add tabletest-formatter for Java and Kotlin - #2860
Merged
Conversation
nedtwigg
commented
Mar 2, 2026
Member
Great PR for a neat formatter!
|
- Remove unused TableTestFormatter field from glue class (fixes SpotBugs) - Add @EnabledForJreRange(min = JAVA_21) to tests (formatter requires Java 21) - Add TableTestFormatterStep to root README feature matrix
nchaugen
commented
Mar 2, 2026
ContributorAuthor
Thanks for the nice feedback! I've added test annotations, removed the unused field that I think upset SpotBugs, and added |
nedtwigg
commented
Mar 2, 2026
Member
Ah, it's a little harder than I realized. In |
nchaugen
commented
Mar 2, 2026
ContributorAuthor
I see. I made inclusion of tableTestFormatter conditional based on Java version. Would that work? |
Uh oh!
There was an error while loading. Please reload this page.
nedtwigg
commented
Mar 2, 2026
Member
Yup :) |
nchaugen
commented
Mar 2, 2026
ContributorAuthor
Awesome! Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds native support for tabletest-formatter, which formats @TableTest tables in Java and Kotlin source files.
All configuration is read from .editorconfig files — only version is exposed in the Spotless DSL.
Follows the glue class pattern (like CleanthatJava, PalantirJavaFormat). Single Maven coordinate: org.tabletest:tabletest-formatter-core:1.0.1.
Verified: testlib:test (271 pass), spotbugsMain, plugin compilation, spotlessApply.