Skip to content

Resolve dependencies per-project - #983

Merged
nedtwigg merged 14 commits into
mainfrom
feat/dep-resolve-per-project
Nov 9, 2021
Merged

Resolve dependencies per-project#983
nedtwigg merged 14 commits into
mainfrom
feat/dep-resolve-per-project

Conversation

@nedtwigg

@nedtwiggnedtwigg commented Nov 7, 2021

Copy link
Copy Markdown
Member

That leads to a lot of duplication, but there is a clear path to recentralize from here if we want to get that performance back. After this PR, spotless can build and run without any warnings from configuration cache. However, it doesn't actually work, and many things will break if you try to do it, although it's surprising how many things do work.

But if you aren't using configuration-cache and you just have a giant multi-module project which has been barfing on our root-project synchronization, this PR is the ultimate fix to #941.

…ll the root-project synchronization problems we were having. I'm keeping the hooks we would need to go back to centralized dep resolution in the future in case we decide to go back to that for some reason.
@nedtwiggnedtwigg changed the title Resolve dependencies per-project (configuration-cache works-ish) (3 of 3)Resolve dependencies per-projectNov 9, 2021
Base automatically changed from feat/spotless-task-service to mainNovember 9, 2021 05:59
@nedtwigg
nedtwigg merged commit 24d1ea5 into mainNov 9, 2021
@nedtwigg
nedtwigg deleted the feat/dep-resolve-per-project branch November 9, 2021 06:14
@nedtwigg

Copy link
Copy Markdown
MemberAuthor

Released in plugin-gradle 6.0.0.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@nedtwigg