Uh oh!
There was an error while loading. Please reload this page.
chore: skpkg with no manual edit - #93
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #93 +/- ##
=======================================
Coverage 93.78% 93.78% =======================================
Files 4 4 Lines 177 177 =======================================
Hits 166 166 Misses 11 11 🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
Looks good. Please see comments. Also make sure the duplicate code of conduct file is deleted and any duplicate workflows like matrix on merge to main
| @@ -16,6 +16,6 @@ jobs: | |||
| with: | |||
| project: diffpy.fourigui | |||
| c_extension: false | |||
| headless: true | |||
| ] | ||
| autodoc_mock_imports = ["h5py", "tkinter", "matplotlib"] |
There was a problem hiding this comment.
Check if these are still needed. Good if they are not needed but presumably they were added before for done reason
| @@ -21,8 +21,7 @@ To get started, please visit the :ref:`Getting started <getting-started>` page. | |||
| Authors | |||
| ======= | |||
| ``diffpy.fourigui`` is developed by Billinge Group | |||
There was a problem hiding this comment.
Please leave all these statements as they were before.
| ############################################################################## | ||
| # | ||
| # (c) 2022-2025 The Trustees of Columbia University in the City of New York. | ||
| # (c) 2026 The Trustees of Columbia University in the City of New York. |
There was a problem hiding this comment.
Please use your new way of doing the copyright
There was a problem hiding this comment.
i.e., 2026 - present, diffpy.fourigui contributors and change it everywhere.
Please could you check that scikit package does it this way and make and issue over there if not? Thanks.
Uh oh!
There was an error while loading. Please reload this page.
@sbillinge ready to review. I have rescikit-packaged it. I maintained all the license info as before. Moreover, I cleaned the duplicated workflow and edit the
README.rstbadge link to make it consistent with the workflow. I have also tested locally and the documentation still renders correctly.