Uh oh!
There was an error while loading. Please reload this page.
Use pip install in GitHub CI to support Gooey for Python 3.13 conda env - #134
Merged
Conversation
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
bobleesj
commented
Nov 21, 2024
| - name: Install diffpy.labpdfproc and requirements | ||
| run: | | ||
| conda install --file requirements/test.txt | ||
| pip install -r requirements/pip.txt |
ContributorAuthor
There was a problem hiding this comment.
pip install under pip.txt
bobleesj
commented
Nov 21, 2024
| - name: Install diffpy.labpdfproc and requirements | ||
| run: | | ||
| conda install --file requirements/test.txt | ||
| pip install -r requirements/pip.txt |
ContributorAuthor
There was a problem hiding this comment.
pip install under pip.txt
bobleesj
commented
Nov 21, 2024
ContributorAuthor
Will fix codecov problem in |
bobleesj
commented
Nov 21, 2024
ContributorAuthor
Yes, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #134 +/- ##
=======================================
Coverage 99.31% 99.31% =======================================
Files 6 6 Lines 293 293 =======================================
Hits 291 291 Misses 2 2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current PR #130 fails since it attempts to
conda installthe Gooey package. However, Gooey's latest conda package support up to py3.10 while the current CI sets up a py3.13 env.Constraint
labpdfprocPython support down to Py3.10..Solution
Impact
labpdfproc, we might have to change the README instructions on how to install labpdfproc.After this PR is merged I will create an GH issue here to ensure we use the reusable CI workflows once Gooey supports 3.13