Uh oh!
There was an error while loading. Please reload this page.
feat: detect extrapolation for morphstretch - #258
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #258 +/- ##
=======================================
Coverage 99.92% 99.92% =======================================
Files 23 24 +1 Lines 1355 1398 +43 =======================================
+ Hits 1354 1397 +43
Misses 1 1
🚀 New features to boost your workflow:
|
ycexiao
commented
Sep 15, 2025
@sbillinge@Sparks29032, it's ready for review. |
Sparks29032
commented
Sep 16, 2025
Tests lgtm |
sbillinge
left a comment
There was a problem hiding this comment.
just a couple of comments, but otherwise lgtm
| def create_morph_data_file( | ||
| data_dir_path, x_morph, y_morph, x_target, y_target | ||
| ): | ||
| morph_file = data_dir_path / "morph_data" |
There was a problem hiding this comment.
do these files end up having an extension? If they are text files maybe make them .txt? But I am not 100% sure what is going on so please advise if I am off base here.
There was a problem hiding this comment.
These files do not end with an extension. This helper function create these files in tmp_dir to facilitate CLI testing when test_func has the corresponding data. I will add the extension ".txt" to make the implementation more explicit.
| ] | ||
| morph_data_text = "\n".join(morph_data_text) | ||
| morph_file.write_text(morph_data_text) | ||
| target_file = data_dir_path / "target_data" |
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
| def create_morph_data_file( | ||
| data_dir_path, x_morph, y_morph, x_target, y_target | ||
| ): | ||
| morph_file = data_dir_path / "morph_data.txt" |
ycexiao
commented
Sep 17, 2025
@sbillinge, it's ready for review. |
Uh oh!
There was an error while loading. Please reload this page.
What problem does this PR address?
Address issues mentioned in #243
morphstretch.What should the reviewer(s) do?
Please check the modifications.