Uh oh!
There was an error while loading. Please reload this page.
Squeeze morph warning handling - #272
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #272 +/- ##
=======================================
Coverage 99.92% 99.93% =======================================
Files 24 24 Lines 1398 1446 +48 =======================================
+ Hits 1397 1445 +48
Misses 1 1
🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
This looks good. Please see comments.
I don't love the name ``--check-increases". It isn't checking anything.
How about --force-monotonic-x for example?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| @pytest.mark.parametrize( | ||
| "squeeze_coeffs, x_morph", | ||
| [ | ||
| # The following squeezes make the function non-monotonic |
There was a problem hiding this comment.
# The following squeezes make the function non-monotonic. Expect code to work but issue the correct warning.
| # call in .py | ||
| x_target = x_morph | ||
| y_target = np.sin(x_target) | ||
| coeffs = [squeeze_coeffs[f"a{i}"] for i in range(len(squeeze_coeffs))] |
There was a problem hiding this comment.
is there a reason you don't just give as "squeeze_coeffs" inputs [-1, -1, 0, 0, 2] and remove this line? I think it would be easier to read. Less cognifive overload for the poor reviewer....
| y_morph = np.sin(x_squeezed) | ||
| morph = MorphSqueeze() | ||
| morph.squeeze = squeeze_coeffs | ||
| with pytest.warns() as w: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Keeps feature of #259 we want per the discussion (see last comment).