Skip to content

Handle IO for (CLI) morph inputs in a function - #274

Merged
sbillinge merged 3 commits into
diffpy:mainfrom
Sparks29032:morph_inputs
Dec 18, 2025
Merged

Handle IO for (CLI) morph inputs in a function#274
sbillinge merged 3 commits into
diffpy:mainfrom
Sparks29032:morph_inputs

Conversation

@Sparks29032

Copy link
Copy Markdown
Collaborator

CLI morph inputs were handled separately in the single morph and two multiple morph functions within morphapp.py. This has been restructured into a function in morph_io.py. Note that Python-only morphs are still handled separately outside this function as they are not enabled for multiple-morphs/targets (since a user can simply write a for loop instead).

@codecov

codecovBot commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (f5fc9ac) to head (8d2ba97).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #274 +/- ##
=======================================
Coverage 99.92% 99.93% =======================================
Files 24 24 Lines 1398 1446 +48 =======================================
+ Hits 1397 1445 +48 
Misses 1 1 

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillingesbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine modulo comments. It needs tests for the logic.

Comment threadsrc/diffpy/morph/morph_io.py
Comment threadsrc/diffpy/morph/morph_io.py Outdated
@sbillinge
sbillinge merged commit 4d1d866 into diffpy:mainDec 18, 2025
7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Sparks29032@sbillinge