Uh oh!
There was an error while loading. Please reload this page.
Give user option to save on original grid - #304
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #304 +/- ##
=======================================
Coverage 99.93% 99.93% =======================================
Files 24 24 Lines 1480 1570 +90 =======================================
+ Hits 1479 1569 +90
Misses 1 1
🚀 New features to boost your workflow:
|
* Add uncertainties for main parameters. * Works for all parameters now * Fix other tests * loosen tolerance to 1e-4 from 1e-5 * Lower tolerance more * Remove comment * [pre-commit.ci] auto fixes from pre-commit hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sparks29032
commented
Jun 1, 2026
CollaboratorAuthor
Good to merge after review. Pretty much only one line has changed.  |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#284.
Default right now is to save the morphed function on the intersected grid. This is the same grid as
--diffreturns the function on as the subtraction occurs on the intersected grid. This PR allows the user to select--original-gridto return the morphed function on the original grid the morph happened on.Tests are written for both the CLI and MorphPy.