Uh oh!
There was an error while loading. Please reload this page.
skpkg: run package update on the repository and support python 3.14 while dropping 3.11 - #162
Conversation
zmx27
commented
Mar 26, 2026
@sbillinge ready for review. I also ran pre-commit with the newly added |
sbillinge
left a comment
There was a problem hiding this comment.
Looks great. Please see comments
| "m2r2", | ||
| ] | ||
| autodoc_mock_imports = [ |
There was a problem hiding this comment.
I am guessing we may need to keep this unless there is a reason you think not
| # |version| and |release|, also used in various other places throughout the | ||
| # built documents. | ||
| fullversion = version(project) |
There was a problem hiding this comment.
Please check that full version is getting defined somewhere
There was a problem hiding this comment.
Yes, fullversion is being defined at the top of the file in the following code snippet:
# Attempt to import the version dynamically from GitHub tag.
try:
fullversion = version("diffpy.pdffit2")
except Exception:
fullversion = "No version found. The correct version will appear in the released version." # noqa: E501
| [tool.codespell] | ||
| exclude-file = ".codespell/ignore_lines.txt" | ||
| ignore-words = ".codespell/ignore_words.txt" | ||
| skip = "*.cif,*.dat,*.cc,*.h" |
There was a problem hiding this comment.
We probably want to keep the .cc and .h here
There was a problem hiding this comment.
Is this line deleted? We don't want it?
zmx27
commented
Mar 26, 2026
@sbillinge ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## migration #162 +/- ##
==========================================
Coverage 98.97% 98.97% ==========================================
Files 6 6 Lines 1270 1270 ==========================================
Hits 1257 1257 Misses 13 13
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Closes#145