Uh oh!
There was an error while loading. Please reload this page.
feat: final parity changes with MATLAB - #205
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #205 +/- ##
==========================================
+ Coverage 77.50% 82.00% +4.50%
==========================================
Files 3 3 Lines 40 50 +10 ==========================================
+ Hits 31 41 +10
Misses 9 9 🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
please see comments. @john-halloran I will merge, but please act on the comments if you can.
| Maximum number of projected-gradient stretch steps per outer-loop | ||
| iteration. Optional. | ||
| stretch_slow_iter : int | ||
| Number of initial outer-loop stretch updates to solve with the |
There was a problem hiding this comment.
Don't change any of these, but moving forward, please use the group standard that descriptions start with "The". In most cases "The" can just be added at the beginning of the existing description. But as I said, don't bother fixing this here, just use the pattern moving forward.
There was a problem hiding this comment.
Thanks for the reminder, will do.
Uh oh!
There was an error while loading. Please reload this page.
sbillinge
commented
Jun 25, 2026
@john-halloran this needs conflict resolution |
Uh oh!
There was an error while loading. Please reload this page.
This is a cleanup PR that brings parity (when other open PRs also merged) with MATLAB on a few remaining points. Since we now converge just as fast, we can use fewer iterations. We can also switch to a faster path when possible, and log the objective function.