Uh oh!
There was an error while loading. Please reload this page.
Move resampler out of parsers, remove relative paths for import - #163
Move resampler out of parsers, remove relative paths for import#163alisnwu wants to merge 8 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #163 +/- ##
=======================================
Coverage 99.17% 99.17% =======================================
Files 7 7 Lines 242 243 +1 =======================================
+ Hits 240 241 +1
Misses 2 2
|
sbillinge
left a comment
There was a problem hiding this comment.
this has gone a bit wrong again. Let's close this and try again.
| def loadData(filename, minrows=10, headers=False, hdel="=", hignore=None, **kwargs): | ||
| def load_data(filename, minrows=10, headers=False, hdel="=", hignore=None, **kwargs): |
There was a problem hiding this comment.
we do not want this change (please see the discussion on #163 ). Please revert.
| class Diffraction_object: | ||
| class DiffractionObject: |
There was a problem hiding this comment.
we want this change, but we want to do it as a deprecation. Please see the discussion on #163
alisnwu
commented
Nov 8, 2024
@sbillinge I've reverted those and now the only changes is the resampler path and removing the relative path imports in parsers |
sbillinge
commented
Nov 8, 2024
@alisnwu I will close this. I was expecting you to do it this way, but we don't want the committee and the reverts in the history. Sorry for the wasted work of reverting commits |
closes#138
All discussions made in #158
@sbillinge Ready for review