Skip to content

Remove scattering_objects folder for importing DiffractionObjects - #189

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
bobleesj:remove-scattering
Dec 3, 2024
Merged

Remove scattering_objects folder for importing DiffractionObjects#189
sbillinge merged 4 commits into
diffpy:mainfrom
bobleesj:remove-scattering

Conversation

@bobleesj

@bobleesjbobleesj commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Closes#182

@bobleesj
bobleesj marked this pull request as ready for review December 2, 2024 20:35
@codecov

codecovBot commented Dec 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (49bb353) to head (16937e7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #189 +/- ##
=======================================
Coverage 97.31% 97.31% =======================================
Files 8 8 Lines 261 261 =======================================
Hits 254 254 Misses 7 7 
Files with missing linesCoverage Δ
tests/diffpy/utils/test_diffraction_objects.py84.61% <100.00%> (ø)

@bobleesj

Copy link
Copy Markdown
ContributorAuthor

@sbillinge ready for review

from

from diffpy.utils.scattering_objects.diffraction_objects import DiffractionObject

to

from diffpy.utils.diffraction_objects import DiffractionObject, PdfObject

@sbillinge

Copy link
Copy Markdown
Contributor

Nicely done, @bobleesj thanks!

@sbillinge
sbillinge merged commit 61412cd into diffpy:mainDec 3, 2024
@bobleesj
bobleesj deleted the remove-scattering branch December 3, 2024 01:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove scattering_object layer

2 participants

@bobleesj@sbillinge