Uh oh!
There was an error while loading. Please reload this page.
Improve wsinterp docstrings and test function - #221
Conversation
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #221 +/- ##
=======================================
Coverage 99.69% 99.69% =======================================
Files 8 8 Lines 325 325 =======================================
Hits 324 324 Misses 1 1
|
Uh oh!
There was an error while loading. Please reload this page.
bobleesj
left a comment
There was a problem hiding this comment.
Ready for review - pls see my in-line comments.
wsinterp docstring and test functionwsinterp docstrings and test functionUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bobleesj
left a comment
There was a problem hiding this comment.
@sbillinge ready for review! - added DOI, didn't add any additional empty liens
bobleesj
commented
Dec 13, 2024
![]() @sbillinge it passes - just codecov.. |
sbillinge
commented
Dec 13, 2024
This looks great, o can merge when it passes. Nor I am greedy though..... Would it be nice if it could take, optionally, a DiffractionObject and return a distraction object? Or maybe it is better to make a method on the DO itself? |
![]() @sbillinge |
bobleesj
commented
Dec 13, 2024
having |
sbillinge
commented
Dec 13, 2024
Yah my thinking too. Actually it is for pdfs, not for diffraction, but for sure there is a PDFObject in our future. |
bobleesj
commented
Dec 13, 2024
I left a comment in the PDF object issue here: #47 Maybe we could merge this, once scikit-package/release-scripts#109 is merged all the way to |


No description provided.