Skip to content

add deprecation warning to resample function - #234

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
alisnwu:resample-dep
Dec 15, 2024
Merged

add deprecation warning to resample function#234
sbillinge merged 1 commit into
diffpy:mainfrom
alisnwu:resample-dep

Conversation

@alisnwu

Copy link
Copy Markdown

closes#139

as per discussion in #180 and #207 warnings.warn passes pytest under python 3.13, 3.12, 3.11

@sbillinge ready for review

Screenshot 2024-12-07 at 5 16 14 PM

@codecov

codecovBot commented Dec 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (891d774) to head (784bc65).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #234 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 8 8 Lines 362 362 =========================================
Hits 362 362 

@sbillinge
sbillinge merged commit d919fef into diffpy:mainDec 15, 2024
@sbillinge

Copy link
Copy Markdown
Contributor

Ah, I see, there was a new PR. Ok, np.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecate legacy resampler?

2 participants

@alisnwu@sbillinge