Uh oh!
There was an error while loading. Please reload this page.
Fix all remaining divide by zero pytest warnings - #262
Conversation
| ] | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
Just moving them under @pytest.mark.parametrize - no numbers have been modified.
| @pytest.mark.parametrize("init_args, expected_error_msg", test_init_invalid_params) | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
I will further refine these comments with higher level commets, etc. in the following PRs (issues have been created for these)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #262 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 8 8 Lines 391 404 +13 =========================================
+ Hits 391 404 +13
|
bobleesj
left a comment
There was a problem hiding this comment.
@sbillinge ready for review - no numbers have been modified.
| def test_d_to_tth(wavelength, d, expected_tth, wavelength_warning_msg): | ||
| if wavelength is None: | ||
| def test_d_to_tth(wavelength, d, expected_tth, divide_by_zero_warning_expected, wavelength_warning_msg): | ||
| if wavelength is None and not divide_by_zero_warning_expected: |
There was a problem hiding this comment.
I am thinking we could make a reusable test util function under conftest.py - that takes in d_to_tth, tth_to_d, etc and capture these warning messages.
Closes#223
This PR focused on catching warnings. In the following PRs, I will focus on checking test comments and refactoring into reusable components with
conftest.py