Uh oh!
There was an error while loading. Please reload this page.
Add class docstring for DiffractionObject - #265
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #265 +/- ##
===========================================
- Coverage 100.00% 98.68% -1.32%
===========================================
Files 8 8 Lines 404 379 -25 ===========================================
- Hits 404 374 -30 - Misses 0 5 +5 |
Uh oh!
There was an error while loading. Please reload this page.
@sbillinge ready for review - cc'ing @yucongalicechen |
sbillinge
left a comment
There was a problem hiding this comment.
this is fantastic! Few small comments inline then we can merge.
| class DiffractionObject: | ||
| """ | ||
| Initialize a DiffractionObject instance. | ||
| A class to represent diffraction data for various scientific experiments involving scattering |
There was a problem hiding this comment.
Let's use the numpy standard. First line is <80 chars and gives a high level statement of the purpose.
Then a blank line. then a more meaty description such as you have here).
There was a problem hiding this comment.
done - do we want to use automatic doc formatting in pre-commit?
# docformatter - formats docstrings in python code
- repo: https://github.com/s-weigand/docformatter
rev: 5757c5190d95e5449f102ace83df92e7d3b06c6c
hooks:
- id: docformatter
additional_dependencies: [tomli]
args: [--in-place, --config, ./pyproject.toml]
??
This basically modifies our code to PEP 257, although it does not fix the length, it does change the format.
There was a problem hiding this comment.
(i can create a separate PR for this)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bobleesj
commented
Dec 22, 2024
@sbillinge ready for review - some comments are "outdated" and no longer displayed under |
bobleesj
commented
Dec 22, 2024
(fixed a quick typo) |

Closes#240 - DiffractionObject docstring do over