Uh oh!
There was an error while loading. Please reload this page.
Config updater workflow - #267
Conversation
I need to get the updated user_filesystem fixture so merging main next
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #267 +/- ##
===========================================
+ Coverage 98.68% 100.00% +1.31%
===========================================
Files 8 8 Lines 379 405 +26 ===========================================
+ Hits 374 405 +31 + Misses 5 0 -5
|
sbillinge
commented
Dec 22, 2024
@bobleesj@yucongalicechen@alisnwu this is ready for review |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
yucongalicechen
commented
Dec 23, 2024
Just another comment - looks like this function does not have docstring yet |
sbillinge
left a comment
There was a problem hiding this comment.
Thanks for the comments @yucongalicechen. I fixed them. Writing the docstring also made me realize we may want to return the status of if a config file is found. Then a user could use the function with the skip but if it returns False make their own workflow, which is nice and flexible. Great reviews everyone!
Uh oh!
There was an error while loading. Please reload this page.
bobleesj
commented
Dec 26, 2024
seems like a conflict created now hm.. |
sbillinge
commented
Dec 26, 2024
Ok, I will fix and merge |
closes#244
This is the new separate workflow for updating the config file if it is found to be missing in home.