Skip to content

Fix get_array_index returns int instead of list in DiffractionObject - #283

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
bobleesj:get-array-index-return
Dec 27, 2024
Merged

Fix get_array_index returns int instead of list in DiffractionObject#283
sbillinge merged 1 commit into
diffpy:mainfrom
bobleesj:get-array-index-return

Conversation

@bobleesj

@bobleesjbobleesj commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Closes#279

@bobleesjbobleesj changed the title Fix test function to check get_array_index returns int instead of listFix get_array_index returns int instead of list in DiffractionObjectDec 27, 2024
bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
Comment threadsrc/diffpy/utils/diffraction_objects.py
@codecov

codecovBot commented Dec 27, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0b6676) to head (faf0e2f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #283 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 8 8 Lines 405 405 =========================================
Hits 405 405
Files with missing linesCoverage Δ
tests/test_diffraction_objects.py100.00% <100.00%> (ø)

bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
Comment threadsrc/diffpy/utils/diffraction_objects.py
bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
Comment threadtests/test_diffraction_objects.py
bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes

@bobleesjbobleesj left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review @sbillinge

@sbillinge
sbillinge merged commit 5a31716 into diffpy:mainDec 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_array_index returns list, instead should be int

2 participants

@bobleesj@sbillinge