Skip to content

Add two test cases for init DiffractionObject with empty xarray and yarray values - #284

Merged
sbillinge merged 2 commits into
diffpy:mainfrom
bobleesj:invalid-tests
Dec 27, 2024
Merged

Add two test cases for init DiffractionObject with empty xarray and yarray values#284
sbillinge merged 2 commits into
diffpy:mainfrom
bobleesj:invalid-tests

Conversation

@bobleesj

@bobleesjbobleesj commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Closes#241

@bobleesjbobleesj mentioned this pull request Dec 27, 2024
Closed
@codecov

codecovBot commented Dec 27, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0b6676) to head (b865a8e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #284 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 8 8 Lines 405 408 +3 =========================================
+ Hits 405 408 +3
Files with missing linesCoverage Δ
tests/test_diffraction_objects.py100.00% <100.00%> (ø)

@bobleesj

bobleesj commented Dec 27, 2024

Copy link
Copy Markdown
ContributorAuthor

@sbillinge ready for review

bobleesj
bobleesj commented Dec 27, 2024
View reviewed changes
Comment threadtests/test_diffraction_objects.py
@sbillinge
sbillinge merged commit 6a9419a into diffpy:mainDec 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

revisit the invalid test DiffractionObject

2 participants

@bobleesj@sbillinge