Uh oh!
There was an error while loading. Please reload this page.
chore: updated pre-commit hook dependencies - #386
Conversation
SYMSCAE
commented
May 29, 2026
@stevenhua0320 PR ready to review. |
stevenhua0320
commented
May 29, 2026
This looks good to me, although the workflow seems not triggering the |
sbillinge
commented
May 29, 2026
please double-check the docformatter tool in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #386 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 10 10 Lines 567 567 =========================================
Hits 567 567 🚀 New features to boost your workflow:
|
stevenhua0320
commented
May 31, 2026
Here is the I think we are right here as we have all these across other packages, so we are safe to merge this. |
| - id: docformatter | ||
| additional_dependencies: [tomli] | ||
| args: [--in-place, --config, ./pyproject.toml] | ||
| language_version: python3.13 |
There was a problem hiding this comment.
What is this? We don't want any pins like this is possible. If a pin is necessary we need an issue to remove it in the future. But better to find a fix that is not a workaround
There was a problem hiding this comment.
We made this is because now we decide to use 1.7.7 docformatter but this version does not support python 3.14, so we add the pin to the python version here. We had to wait for the 1.7.8 wierd deleting line bug to fix so that we could remove the pin and I think everything would work smoothly again. So, we should make an issue and notify future developers to remove this pin and change to 1.7.8 version when the bug is fixed. I also made the update to the issue #385
There was a problem hiding this comment.
we will have to find another workaround with 1.7.8
This reverts commit 4b7583e.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR performs pre-commit hook maintenance by updating tooling hook revisions.
Changes
blackfrom26.3.1to26.5.1isortfrom8.0.1to9.0.0a3