Uh oh!
There was an error while loading. Please reload this page.
Add scons options for compilation verbosity - #104
Open
clemisch wants to merge 2 commits into
Open
Conversation
Warning! No news item is found for this PR. If this is a user-facing |
clemisch
commented
Aug 24, 2026
ContributorAuthor
I'll add the news item after we discussed the rest and came to an agreement ;-) |
vincefn
commented
Aug 24, 2026
Collaborator
If we move towards nanobind, the proposed branch switched to cmake, so it may supersede this. And it would remove |
clemisch
commented
Aug 24, 2026
ContributorAuthor
Yeah but how soon will that be, realistically? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(essentially the same as diffpy/libobjcryst#32)
Currently the manual compilation with
scons devis quite noisy: it prints all compiler commands and all compiler warnings. There is no flag to control it.For development I found that annoying, mainly because it's hard to spot an error in the wall of warnings.
This PR adds scons flags
verbose: true|false = falseandwarnigns: all|default|none = none.verbosecontrols if compiler commands are printed.warningscontrols compiler warnings. For the latter:I think it's more common to show warnings on demand rather than by default, but that's kinda subjective and I'm happy to change the default to
warnings=allandverbose=true. That would mimick current behavior.