Skip to content

makeNdArray: return pyarray directly instead of bp::incref #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincefn merged 3 commits into from
Aug 25, 2026
+24 −1
Merged

makeNdArray: return pyarray directly instead of bp::incref #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1e876a
Return pyarray directly instead of bp::incref to avoid memory ballooning
Jun 18, 2026
a7d3e1e
add news file
clemisch Aug 25, 2026
89bfc04
[pre-commit.ci] auto fixes from pre-commit hooks
pre-commit-ci[bot] Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions news/fix_pyarray_ref.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* Fix memory leak in makeNdArray

**Security:**

* <news item>
2 changes: 1 addition & 1 deletion src/extensions/registerconverters.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,7 @@ PyObject* makeNdArray(const double* data, std::vector<npy_intp>& dims)
PyArrayObject* a = reinterpret_cast<PyArrayObject*>(pyarray);
double* adata = static_cast<double*>(PyArray_DATA(a));
std::copy(data, data + PyArray_SIZE(a), adata);
return bp::incref(pyarray);
return pyarray;
}

// CrystVector to ndarray
Expand Down
Loading