Uh oh!
There was an error while loading. Please reload this page.
Add bindings to ReflectionProfile methods - #79
Conversation
This reverts commit 7253d99.
vincefn
commented
Nov 7, 2025
Hi @ezatterin - thanks for the changes and the fix. Could you add a unit test (for good measure) with the new functions ? I think the PR also needs a |
sbillinge
commented
Nov 7, 2025
yes, thanks @ezatterin and @vincefn . The news will turn into the changelog at the next release. |
* GetProfile now accepts numpy arrays as the `x` argument
ezatterin
commented
Nov 21, 2025
Finally made it 🚀 I had to add an additional wrapper to use the |
sbillinge
commented
Nov 30, 2025
Thanks @ezatterin We will review. I added this to the |
sbillinge
commented
Apr 6, 2026
@vincefn please can you check you are ok to merge this? We are moving things forward to the next release so it would be nice to have this in there. @ezatterin do you think documentation is adequate for folks to know how to use this? Bear in mind that we auto-build API docs from the docstrings, so if these are just library capabilities that may be enough, but if there are interesting things to do with this we could put an example in the docs. |
vincefn
commented
Apr 7, 2026
This looks fine for me, even if I have not had the time to test all the details (notably the changes of the setup.py). |
sbillinge
commented
Apr 7, 2026
@vincefn that is a good point. We should test the build with the new I will wait for @ezatterin to comment and then merge. |
@sbillinge Apologies it took me a while to reply - busy month. I added a (tested!) usage example to the |
sbillinge
commented
Jun 19, 2026
@stevenhua0320 would it be possible for you to put in a PR to this repo with updates to the pre-commit.yml so that we can make it pass in the CI? Thanks so much. |
vincefn
commented
Jul 28, 2026
pre-commit.ci run |
Uh oh!
There was an error while loading. Please reload this page.
Summary of changes:
allow to build the library via
pip install .outside of a conda env usingsysconfigto find the location of the shared libs.added python bindings for the
ReflectionProfilepublic methods:Tested on Ubuntu 24.04 and Windows 11.