fix(web): stop stretching the grid behind the thank-you band - #267
Merged
Merged
Conversation
The grid read as heavy because it was being distorted, not because it was too strong. hero-vector-grid.svg is preserveAspectRatio="none", so it fills whatever box it is handed rather than holding its own shape, and the band gave it roughly 1440x430 from a 730x708 source. That drew the vertical lines about three times thicker than the horizontal ones and turned the square cells into wide rectangles. Holding the source ratio restores square cells and hairline strokes; the band's overflow-hidden crops the excess. The page that owns this asset renders it at native size for the same reason, so this matches rather than invents. Opacity 0.5 to 0.35 on top of that, and a minHeight floor for narrow viewports where the band can outgrow the ratio. Measured worst case was /thank-you/deal-registration at 375px, where the grid reached 97% of the band and left a sliver at the foot; the floor costs 3% of stretch there and nothing anywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit, one file, apps/web only.
The gridlines behind the thank-you band read as heavy because the asset was being distorted, not because it was too strong.
hero-vector-grid.svgispreserveAspectRatio="none", so it fills whatever box it is handed rather than holding its own shape, and the band gave it roughly 1440x430 from a 730x708 source. That drew the vertical lines about three times thicker than the horizontal ones and turned the square cells into wide rectangles.Holding the source ratio restores square cells and hairline strokes; the band's
overflow-hiddencrops the excess. The page that owns this asset renders it at native size for the same reason, so this matches an existing treatment rather than inventing one. Opacity 0.5 to 0.35 on top.A
minHeightfloor covers narrow viewports where the band can outgrow the ratio. Measured worst case was/thank-you/deal-registrationat 375px, where the grid reached 97% of the band and left a sliver at its foot; the floor costs 3% of stretch there and nothing elsewhere.The shared SVG is untouched, so the two other pages that use it are unaffected.
lint, typecheck and build all pass; all four thank-you routes prerender.