Uh oh!
There was an error while loading. Please reload this page.
Conversation
dwhieb
commented
Aug 16, 2020
MemberAuthor
vadekh
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
closes#144
Description
This PR adds the
Model.defineArrayProp()utility method, which defines an array property on an object where each item in the array is expected to be an instance of a particular class/model. When the user sets this property to a new array, each item in the array is transformed into an instance of the provided class/model.This method does not prevent users from adding items to the array which are not instances of the model. (Issue #142 creates a Collection class which is used for this purpose.)
Checklist
Check out the Contributing Guidelines if you need help getting started with your pull request.
Open an issue for the change (if one doesn't already exist).
Update tests for planned changes. Check that they are failing. (
npm test)Write code to pass the tests. (
npm test)Add inline code commenting (using JSDoc style). Add links to cross-referenced modules, and the DLx data format.
Generate the developer documentation (
npm run docs) and check your changes by openingdocs/index.htmlin a browser.