Skip to content

Collection - #149

Merged
dwhieb merged 9 commits into
masterfrom
issue-142
Aug 18, 2020
Merged

Collection#149
dwhieb merged 9 commits into
masterfrom
issue-142

Conversation

@dwhieb

Copy link
Copy Markdown
Member

Related Issue

closes#142

Description

Adds a Collection class to /core, which is a subclass of the native Array object. The Collection ensures that its items are always an instance of the class/model provided to it on instantiation.

Checklist

  • Check out the Contributing Guidelines if you need help getting started with your pull request.

  • Open an issue for the change (if one doesn't already exist).

  • Update tests for planned changes. Check that they are failing. (npm test)

  • Write code to pass the tests. (npm test)

  • Add inline code commenting (using JSDoc style). Add links to cross-referenced modules, and the DLx data format.

  • Generate the developer documentation (npm run docs) and check your changes by opening docs/index.html in a browser.

@dwhiebdwhieb added feature Changes that affect the API core Core models and utilities labels Aug 17, 2020
@dwhieb
dwhieb requested a review from vadekhAugust 17, 2020 00:06
@dwhiebdwhieb self-assigned this Aug 17, 2020
@dwhiebdwhieb changed the title Issue 142CollectionAug 17, 2020
@dwhieb

Copy link
Copy Markdown
MemberAuthor

Comment threadsrc/core/index.test.js
@dwhieb
dwhieb requested a review from vadekhAugust 18, 2020 19:12
@dwhieb
dwhieb merged commit b5add78 into masterAug 18, 2020
@dwhieb
dwhieb deleted the issue-142 branch August 18, 2020 19:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore models and utilitiesfeatureChanges that affect the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collection

2 participants

@dwhieb@vadekh