Uh oh!
There was an error while loading. Please reload this page.
Conversation
dwhieb
commented
Aug 17, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vadekh
commented
Aug 17, 2020
@dwhieb I also noticed that this is the only PR where node is upgraded to 14.x was that update to |
dwhieb
commented
Aug 18, 2020
@vadekh I forgot to update the workflow file to v14 when I updated this library to v14 the other week. As a result some of the tests broke on continuous integration in GitHub Actions, even though they were passing locally. This is because I used some newer syntax (nullish coalescence) that's supported in v14 but not v13. |
dwhieb
commented
Aug 18, 2020
@vadekh Addressed all your suggested changes. This one should be good to go! Go and and merge into |
Related Issue
closes#145
Description
Adds an Utterance class with the following properties:
transcript(Transcription)transcription(Transcription)translation(MultiLangString)Checklist
Check out the Contributing Guidelines if you need help getting started with your pull request.
Open an issue for the change (if one doesn't already exist).
Update tests for planned changes. Check that they are failing. (
npm test)Write code to pass the tests. (
npm test)Add inline code commenting (using JSDoc style). Add links to cross-referenced modules, and the DLx data format.
Generate the developer documentation (
npm run docs) and check your changes by openingdocs/index.htmlin a browser.