Skip to content

Utterance - #150

Merged
vadekh merged 14 commits into
masterfrom
issue-145
Aug 18, 2020
Merged

Utterance#150
vadekh merged 14 commits into
masterfrom
issue-145

Conversation

@dwhieb

@dwhiebdwhieb commented Aug 17, 2020

Copy link
Copy Markdown
Member

Related Issue

closes#145

Description

Adds an Utterance class with the following properties:

  • transcript (Transcription)
  • transcription (Transcription)
  • translation (MultiLangString)

Checklist

  • Check out the Contributing Guidelines if you need help getting started with your pull request.

  • Open an issue for the change (if one doesn't already exist).

  • Update tests for planned changes. Check that they are failing. (npm test)

  • Write code to pass the tests. (npm test)

  • Add inline code commenting (using JSDoc style). Add links to cross-referenced modules, and the DLx data format.

  • Generate the developer documentation (npm run docs) and check your changes by opening docs/index.html in a browser.

@dwhiebdwhieb added feature Changes that affect the API models Changes to the models module labels Aug 17, 2020
@dwhieb
dwhieb requested a review from vadekhAugust 17, 2020 01:05
@dwhiebdwhieb self-assigned this Aug 17, 2020
@dwhieb

Copy link
Copy Markdown
MemberAuthor

Comment threadsrc/models/index.js
Comment threadsrc/models/index.test.js
@vadekh

Copy link
Copy Markdown
Member

@dwhieb I also noticed that this is the only PR where node is upgraded to 14.x was that update to .github/workflows/test.yml intentional?

@dwhieb

Copy link
Copy Markdown
MemberAuthor

@vadekh I forgot to update the workflow file to v14 when I updated this library to v14 the other week. As a result some of the tests broke on continuous integration in GitHub Actions, even though they were passing locally. This is because I used some newer syntax (nullish coalescence) that's supported in v14 but not v13.

@dwhieb

Copy link
Copy Markdown
MemberAuthor

@vadekh Addressed all your suggested changes. This one should be good to go! Go and and merge into master when you've approved it.

@dwhieb
dwhieb requested a review from vadekhAugust 18, 2020 19:24
@vadekh
vadekh merged commit fc47758 into masterAug 18, 2020
@vadekh
vadekh deleted the issue-145 branch August 18, 2020 19:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureChanges that affect the APImodelsChanges to the models module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utterance

2 participants

@dwhieb@vadekh