Skip to content

Text - #152

Merged
dwhieb merged 24 commits into
masterfrom
issue-141
Aug 18, 2020
Merged

Text#152
dwhieb merged 24 commits into
masterfrom
issue-141

Conversation

@dwhieb

Copy link
Copy Markdown
Member

Related Issue

closes#141

Description

Adds a Text model with title and utterances properties.

Checklist

  • Check out the Contributing Guidelines if you need help getting started with your pull request.

  • Open an issue for the change (if one doesn't already exist).

  • Update tests for planned changes. Check that they are failing. (npm test)

  • Write code to pass the tests. (npm test)

  • Add inline code commenting (using JSDoc style). Add links to cross-referenced modules, and the DLx data format.

  • Generate the developer documentation (npm run docs) and check your changes by opening docs/index.html in a browser.

@dwhieb
dwhieb requested a review from vadekhAugust 17, 2020 02:03
@dwhiebdwhieb self-assigned this Aug 17, 2020
@dwhiebdwhieb added the models Changes to the models module label Aug 17, 2020
@dwhieb

Copy link
Copy Markdown
MemberAuthor

[javascript] Text

@vadekhvadekh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to add Text to src/index again.

@dwhieb

Copy link
Copy Markdown
MemberAuthor

Text added to src/index.js and accompanying test.

@dwhieb
dwhieb requested a review from vadekhAugust 18, 2020 19:34
@dwhieb
dwhieb merged commit 91f3b0b into masterAug 18, 2020
@dwhieb
dwhieb deleted the issue-141 branch August 18, 2020 19:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modelsChanges to the models module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text

2 participants

@dwhieb@vadekh