Skip to content

Word - #155

Merged
dwhieb merged 4 commits into
masterfrom
issue-154
Aug 27, 2020
Merged

Word#155
dwhieb merged 4 commits into
masterfrom
issue-154

Conversation

@dwhieb

@dwhiebdwhieb commented Aug 26, 2020

Copy link
Copy Markdown
Member

This PR adds a Word model, as well as Utterance.words. closes#154

  • Improved a lot of the JSDoc comments so that the developer documentation is more readable.
  • Added Model.defineValidatedProp, which defines a property on an object that has to be validated using a validation function. The validation function should throw an error if validation fails.
  • Had to stop using most private class properties. It turns out the way I was initializing them in Object.defineProperties wasn't actually doing what I thought it was. Short story: You can't access private properties (#prop) using bracket notation (this[prop]). So I adjusted the static methods on Model to compensate.

@dwhieb
dwhieb requested a review from vadekhAugust 26, 2020 06:23
@dwhiebdwhieb self-assigned this Aug 26, 2020
@dwhiebdwhieb added the models Changes to the models module label Aug 26, 2020
@dwhieb

Copy link
Copy Markdown
MemberAuthor

[javascript] Word

@dwhiebdwhieb mentioned this pull request Aug 27, 2020
@dwhiebdwhieb added the feature Changes that affect the API label Aug 27, 2020
@dwhieb

Copy link
Copy Markdown
MemberAuthor

@vadekh I need to merge this to use it in the app, but you're welcome to still review it and suggest changes.

@dwhieb
dwhieb merged commit c12f991 into masterAug 27, 2020
@dwhieb
dwhieb deleted the issue-154 branch August 27, 2020 18:33
Comment threadsrc/models/Text.js
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureChanges that affect the APImodelsChanges to the models module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Word

2 participants

@dwhieb@vadekh