Skip to content

Graphviz - #644

Open
james-d-mitchell wants to merge 3 commits into
digraphs:mainfrom
james-d-mitchell:graphviz
Open

Graphviz#644
james-d-mitchell wants to merge 3 commits into
digraphs:mainfrom
james-d-mitchell:graphviz

Conversation

@james-d-mitchell

@james-d-mitchelljames-d-mitchell commented May 7, 2024

Copy link
Copy Markdown
Member

This is a reworking of #639, which goes a bit further than #639 in removing the old stuff for displays. This PR doesn't introduce any breaking changes except that we now require the graphviz package. So this PR shouldn't be merged until there is a release of `graphviz'.

@james-d-mitchell

james-d-mitchell commented May 7, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

TODO:

  • doc
  • tests for code coverage

@james-d-mitchelljames-d-mitchell mentioned this pull request May 7, 2024
Merged
@james-d-mitchelljames-d-mitchell added major A label for PRs or issues that are major in some sense. refactor Label for PRs or issues related to refactoring code labels May 8, 2024
@james-d-mitchell
james-d-mitchellforce-pushed the graphviz branch 10 times, most recently from b35efd9 to d4b6e10CompareMay 10, 2024 12:35
@james-d-mitchelljames-d-mitchell mentioned this pull request May 10, 2024
Closed
@james-d-mitchell
james-d-mitchellforce-pushed the graphviz branch 5 times, most recently from 19fe156 to 5416f88CompareMay 15, 2024 12:09
@james-d-mitchell

james-d-mitchell commented May 15, 2024

Copy link
Copy Markdown
MemberAuthor

The CI will likely fail here until:

digraphs/graphviz#21

is merged.

@james-d-mitchelljames-d-mitchell mentioned this pull request May 15, 2024
Open
@james-d-mitchelljames-d-mitchell added the gap-days-brussels-2025 Label for things we might work on in Brussels label Apr 7, 2025
@james-d-mitchell

james-d-mitchell commented Apr 7, 2025

Copy link
Copy Markdown
MemberAuthor

This might be a bit much for this week, but maybe not.

@james-d-mitchelljames-d-mitchell removed the gap-days-brussels-2025 Label for things we might work on in Brussels label Apr 9, 2025
wilfwilson
wilfwilson reviewed Aug 27, 2025
View reviewed changes

@wilfwilsonwilfwilson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!

Comment threaddoc/main.xml Outdated
Comment threaddoc/display.xml
<#GAPDoc Label="GraphvizVertexLabelledDigraph">
<ManSection>
<Attr Name="GraphvizVertexLabelledDigraph" Arg="D"/>
<Attr Name="GraphvizVertexLabelledGraph" Arg="D"/>

@wilfwilsonwilfwilsonAug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, I was wishing we had such a function already yesterday.

Comment threaddoc/display.xml
<Description>
These functions produce &graphviz; objects representing the digraph
<A>D</A>, where the vertices in the list <A>verts</A>, and edges
between them, are drawn with color <A>color1</A> and all other vertices

@wilfwilsonwilfwilsonAug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the text of the Digraphs manual, we sometimes use the US spelling color and sometimes we use the British spelling colour. I suggest we standardise at some point.

Comment thread.github/workflows/gap.yml Outdated
Comment thread.github/workflows/gap.yml Outdated
Comment threadetc/code-coverage-test-c.py

@wilfwilsonwilfwilsonAug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file part of this PR? Should it be a separate one?

Comment threadgap/cliques.gi
@wilfwilson
wilfwilsonforce-pushed the graphviz branch 2 times, most recently from 4aee2cd to e5a6048CompareOctober 3, 2025 13:50
@wilfwilson

wilfwilson commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

I've rebased this on main to resolve the merge conflict and see how the tests are running, and remove a couple of obsolete/untracked files, hope you don't mind @james-d-mitchell.

@wilfwilsonwilfwilson mentioned this pull request Oct 3, 2025
Open
@james-d-mitchell

james-d-mitchell commented Oct 7, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks @wilfwilson don't mind even a little bit

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilfwilsonwilfwilsonwilfwilson left review comments

Assignees

No one assigned

Labels

majorA label for PRs or issues that are major in some sense.refactorLabel for PRs or issues related to refactoring code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@james-d-mitchell@wilfwilson