Uh oh!
There was an error while loading. Please reload this page.
Added a helper function and updated the existing methods to preserve edge weights when removing vertices, edges or copying digraphs (issue #683) - #877
Conversation
…edge weights when removing vertices, edges or copying digraphs (issue digraphs#683)
mtorpey
commented
Oct 31, 2025
This looks like it's coming along. Could you please:
It'd be great if you could do this by next meeting, so we can do a proper review of your two PRs. |
Uh oh!
There was an error while loading. Please reload this page.
mtorpey
commented
Nov 12, 2025
Looks like linting is improved! If you could now add tests, that should satisfy the codecov check. |
…igraphRemoveVertex and related immutable operations. Also added testing.
mtorpey
left a comment
There was a problem hiding this comment.
Subject to what we've said above, it'd be nice to see documentation. But this is coming along well.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mtorpey
commented
Nov 24, 2025
Documentation should be installed in doc/z-chap5.xml |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…the weights correctly. Split the DigraphImmutableCopy into a helper DigraphImmutableCopyNoWeights to copy the weights correctly.
devansh2605
commented
Dec 3, 2025
@mtorpey I have added edge-weighted to the failing tests but the |
| digraph. <P/> | ||
| This can be useful when modifying the structure of a digraph with | ||
| <Ref Oper="DigraphRemoveVertex"/> or <Ref Oper="DigraphRemoveEdge"/>, |
There was a problem hiding this comment.
I think this last reference needs to be
<Ref Oper="DigraphRemoveEdge" Label="for a digraph and an edge"/>
to allow the manual tests to pass.
Issue -
https://github.com/digraphs/Digraphs/issues/683Previously, deleting vertices or edges from an EdgeWeightedDigraph or taking a mutable copy caused the resulting digraph to lose its edge weights. This commit is just a layout for which I'll add tests and debug.
Changes include:
CopyEdgeWeightsForSubdigraphhelper function to reconstruct weights after vertex removals.DigraphRemoveVertexto copy edge weights.DigraphRemoveEdgeto remove corresponding weight entries instead of dropping all weights.DigraphMutableCopyto copy edge weights when present.digraph.gd.