Uh oh!
There was an error while loading. Please reload this page.
gha: update actions, and update to go1.21, go1.22 - #16
Merged
Conversation
thaJeztah
commented
Jul 15, 2024
Member
- gha: update actions/checkout@v4
- gha: update actions/setup-go@v5
- gha: update golangci/golangci-lint-action@v6
- gha: update codecov/codecov-action@v4
- gha: update golangci-lint to v1.59
- gha: update to go1.21.x, go1.22.x
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Error: fuzz_test.go:11:14: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
f.Fuzz(func(t *testing.T, data string) {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #16 +/- ##
==========================================
+ Coverage 83.71% 84.21% +0.49%
==========================================
Files 5 5 Lines 393 304 -89 ==========================================
- Hits 329 256 -73 + Misses 54 38 -16
Partials 10 10 ☔ View full report in Codecov by Sentry. |
1 task
milosgajdos
approved these changes
Jul 15, 2024
milosgajdos
commented
Jul 18, 2024
Member
@thaJeztah do you want to squash? |
thaJeztah
commented
Jul 18, 2024
MemberAuthor
It's probably fine to keep them separate; each of them is for a specific dependency, so they don't really depend on each other. |
thaJeztah
commented
Jul 18, 2024
MemberAuthor
(if that's good to you that is) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.