Skip to content

remove internal uses of ReferenceRegexp - #27

Merged
milosgajdos merged 1 commit into
distribution:mainfrom
thaJeztah:internalize_ReferenceRegexp
Apr 18, 2026
Merged

remove internal uses of ReferenceRegexp#27
milosgajdos merged 1 commit into
distribution:mainfrom
thaJeztah:internalize_ReferenceRegexp

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Apr 18, 2026

Copy link
Copy Markdown
Member

remove internal uses of ReferenceRegexp

Split into a non-exported and exported regex, and use the non-exported regex internally.

@codecov

codecovBot commented Apr 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.21%. Comparing base (2bae058) to head (6ccba5a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #27 +/- ##
=======================================
Coverage 84.21% 84.21% =======================================
Files 5 5 Lines 304 304 =======================================
Hits 256 256 Misses 38 38 Partials 10 10 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Split into a non-exported and exported regex, and use the non-exported
regex internally.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the internalize_ReferenceRegexp branch from 80f2caa to 6ccba5aCompareApril 18, 2026 15:22
@thaJeztah
thaJeztah marked this pull request as ready for review April 18, 2026 15:22
@milosgajdos
milosgajdos merged commit 0965666 into distribution:mainApr 18, 2026
13 checks passed
@thaJeztah
thaJeztah deleted the internalize_ReferenceRegexp branch April 18, 2026 16:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah@milosgajdos