This repository was archived by the owner on May 24, 2026. It is now read-only.
Keymaster RMA support - #132
Merged
mdwivedi merged 2 commits intoMay 24, 2022
Merged
Conversation
Javacard km 41 aosp upmerge 0630
subrahmanyamanforce-pushed
the
keymaster_rma_support
branch
8 times, most recently
from
May 20, 2022 06:15
f9b87df to
51b2ab2Compare| short packageVersion_ = 0x100; | ||
| byte provisionStatus_ = firstByte; | ||
| if (firstByte == KMKeymasterApplet.KM_MAGIC_NUMBER) { | ||
| packageVersion_ = element.readShort(); |
ContributorAuthor
There was a problem hiding this comment.
rename to oldpackageVersion.
packageVersion_ change to 0.
if KM_MAGIC_NUMBER is not there return upgrade not allowed.
| switch(packageVersion) { | ||
| case 0x100: // 1.0 | ||
| // Never comes here when KM_PERSISTENT_DATA_STORAGE_VERSION = 0x201 | ||
| handleDataUpgradeToVersion2_0(); |
ContributorAuthor
There was a problem hiding this comment.
Remove this code for 1.0 to 2.0 from all the classes. repository and seProvider.
Make the release to 3.0 and renamed the name to KM_PERSISTENT_DATA_STORAGE_VERSION to KM_APPLET_PACKAGE_VERSION.
Write a comment when ever an applet upgrade is there please change the version either to minor and major.
| private void handleDataUpgradeToVersion2_1() { | ||
| // Please note that this is a dummy key. Replace below key with a real OEM Root | ||
| // public key while upgrading the Applet from data version 2.0 to 2.1. This change | ||
| // is not required if the Applet is installed first time with version 2.1. |
ContributorAuthor
There was a problem hiding this comment.
Write the type of key. EC Key P256 curve.
| } | ||
| @Override | ||
| public byte[] getOEMRootPublicKey() { |
ContributorAuthor
There was a problem hiding this comment.
Follow the same pattern pass the buffer as input to copy
subrahmanyamanforce-pushed
the
keymaster_rma_support
branch
2 times, most recently
from
May 24, 2022 02:11
a0c071a to
a839d44Comparesubrahmanyamanforce-pushed
the
keymaster_rma_support
branch
from
May 24, 2022 03:02
a839d44 to
3484559CompareAvinashHedage pushed a commit
to AvinashHedage/JavaCardKeymaster
that referenced
this pull request
Jan 25, 2023
…mmnet_fixes Keymint 300 rkp comments fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.