Skip to content
This repository was archived by the owner on May 24, 2026. It is now read-only.

Block cmds till negotiation - #147

Merged
mdwivedi merged 2 commits into
divegeek:Javacard_KM_41_AOSP_UPMERGE_0630from
subrahmanyaman:block_cmds_till_negotiation
Jun 7, 2022
Merged

Block cmds till negotiation#147
mdwivedi merged 2 commits into
divegeek:Javacard_KM_41_AOSP_UPMERGE_0630from
subrahmanyaman:block_cmds_till_negotiation

Conversation

@subrahmanyaman

Copy link
Copy Markdown
Contributor

No description provided.

public static final short KEYBLOB_CURRENT_VERSION = 1;
// KeyBlob Verion 1 constant.
public static final short KEYBLOB_VERSION_0 = 0;
// Device reboot states

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write comment about these states.

byte deviceRebootStatus = repository.getBootEndedStatus();
if (0 != (deviceRebootStatus & SET_BOOT_PARAMS_SUCCESS) &&
0 != (deviceRebootStatus & SET_BOOT_ENDED_SUCCESS) &&
0 != (deviceRebootStatus & SET_SYSTEM_PROPERTIES_SUCCESS) &&

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare with 0x0F

case INS_GENERATE_KEY_CMD:
case INS_IMPORT_KEY_CMD:
case INS_IMPORT_WRAPPED_KEY_CMD:
case INS_ATTEST_KEY_CMD:

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getHwInfo, addRngEntropy allowed.
Return UNKNOWN_ERROR from here.

@subrahmanyaman
subrahmanyamanforce-pushed the block_cmds_till_negotiation branch from fa0707f to 9626d54CompareJune 6, 2022 22:31
@subrahmanyaman
subrahmanyamanforce-pushed the block_cmds_till_negotiation branch from 9626d54 to eeb2d76CompareJune 6, 2022 22:38
@mdwivedi
mdwivedi merged commit 9ab6539 into divegeek:Javacard_KM_41_AOSP_UPMERGE_0630Jun 7, 2022
@subrahmanyaman
subrahmanyaman deleted the block_cmds_till_negotiation branch June 7, 2022 04:15
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@subrahmanyaman@mdwivedi