Skip to content
This repository was archived by the owner on May 24, 2026. It is now read-only.

Return CANNOT_ATTEST_IDS instead of UNIMPLEMENTED in case DEVICE_UNIQUE_ATTESTATION tag is found#21

Merged
divegeek merged 2 commits into from
Feb 26, 2021
Merged

Return CANNOT_ATTEST_IDS instead of UNIMPLEMENTED in case DEVICE_UNIQUE_ATTESTATION tag is found #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b4775
Merge pull request #56 from divegeek/master
BKSSMVenkateswarlu Feb 20, 2021
9d57e3f
A Strongbox implementation need not support support DEVICE_UNIQUE_ATT…
Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Applet/src/com/android/javacard/keymaster/KMError.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ public class KMError {
public static final short KEY_REQUIRES_UPGRADE = 62;

public static final short ATTESTATION_APPLICATION_ID_MISSING = 65;
public static final short CANNOT_ATTEST_IDS = 66;
public static final short ROLLBACK_RESISTANCE_UNAVAILABLE = 67;

public static final short DEVICE_LOCKED = 72;
Expand Down
2 changes: 1 addition & 1 deletion Applet/src/com/android/javacard/keymaster/KMKeymasterApplet.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1388,7 +1388,7 @@ private void processAttestKeyCmd(APDU apdu) {
KMKeyParameters.findTag(
KMType.BOOL_TAG, KMType.DEVICE_UNIQUE_ATTESTATION, data[KEY_PARAMETERS]);
if (tmpVariables[0] != KMType.INVALID_VALUE) {
KMException.throwIt(KMError.UNIMPLEMENTED);
KMException.throwIt(KMError.CANNOT_ATTEST_IDS);
}
// The key which is being attested should be asymmetric i.e. RSA or EC
tmpVariables[0] = KMEnumTag.getValue(KMType.ALGORITHM, data[HW_PARAMETERS]);
Expand Down