Skip to content

fix(parser): attributes are not always propagated/populated - #466

Draft
ljmf00 wants to merge 1 commit into
dlang-community:masterfrom
ljmf00:fix-attributes
Draft

fix(parser): attributes are not always propagated/populated#466
ljmf00 wants to merge 1 commit into
dlang-community:masterfrom
ljmf00:fix-attributes

Conversation

@ljmf00

@ljmf00ljmf00 commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Co-authored-by: Eyal Lotem eyal@weka.io
Signed-off-by: Luís Ferreira contact@lsferreira.net


Adapted from weka@caac5e4 to upstream. CC @EyalIO .

Fixes#370 and somewhat related to #73.

Co-authored-by: Eyal Lotem <eyal@weka.io>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00

Copy link
Copy Markdown
ContributorAuthor

Still requires testing.

@codecov

codecovBot commented Sep 17, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.20%. Comparing base (19a8489) to head (b717b20).
⚠️ Report is 76 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #466 +/- ##
==========================================
+ Coverage 83.17% 83.20% +0.03% 
==========================================
Files 11 11 Lines 8338 8338 ==========================================
+ Hits 6935 6938 +3 + Misses 1403 1400 -3 
Files with missing linesCoverage Δ
src/dparse/parser.d91.39% <100.00%> (+0.08%)⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a8489...b717b20. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WebFreak001

Copy link
Copy Markdown
Member

we have the XPath based testing framework setup for this, I think that's the easiest way to test for an AST modification like this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attributes broken?

2 participants

@ljmf00@WebFreak001