GitHub Workflow: Clean up CI workflow to avoid redundant work. - #655
GitHub Workflow: Clean up CI workflow to avoid redundant work.#655KimonHoffmann wants to merge 5 commits into
Conversation
1c87679 to
429baf4
Compare
b7dbf21 to
4ba642c
Compare
vt-tv
left a comment
There was a problem hiding this comment.
I'm not a github action expert by any means but I can't seem to find when/how the new reuse.yml workflow is invoked. I don't see any trace of it in the build logs.
It is (now) a separate workflow with its separate trigger that runs independently of the CI build. See |
|
See also: |
|
@KimonHoffmann should we backport to 1.1 or focus only on main? if so, please add the required labels. |
We could, yes. I'll add the labels accordingly. |
| " | ||
|
|
||
| build_c_cxx: | ||
| name: Build C library on Ubuntu |
There was a problem hiding this comment.
While we are at it: All jobs render exactly the same name, and in the workflow run overview it is sometimes hard to see which one is which.
What about something like:
Build C/C++ on ${{ matrix.architecture }} - ${{ matrix.compiler }}
There was a problem hiding this comment.
Hmmm, I removed the labels exactly, because the jobs already contain the matrix axes combination as part of their name?! (In parentheses, after the main title) Does that not render like that for you?
I found the redundant mention of the axes combination unpleasant and thus removed them.
| echo "This pull request originates from the base repository." | ||
| echo "is-fork=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| - name: Set up QEMU |
There was a problem hiding this comment.
With arm64 runners, do we still need qemu?
There was a problem hiding this comment.
Not strictly, but having it available doesn't hurt and easily allows adding other architectures in the future that might not have dedicated runners available.
I also contemplated the removal, because I only switched to arm-native runners later in the refactor, making qemu obsolete. But for the reason above I opted to keep it around.
Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
…tectures. Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
4ba642c to
0b9c7bf
Compare
Orthogonalize the CI workflow by separating out redundant steps that were previously lumped in with other variations.
Details
Backport requirements
None.
Beneficial to have on all active branches, so labels have been added accordingly.
Notes
Once this branch has been merged it is important to update the PR merge requirements & status checks for the newly structured CI steps (which is why this PR currently claims that 6 status checks are missing).