HTML API: Implement active format reconstruction - #13
Closed
dmsnell wants to merge 8 commits into
Closed
Conversation
sirreal
reviewed
Jan 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
| @@ -1472,15 +1472,19 @@ private function generate_implied_end_tags_thoroughly() { | |||
| * @return bool Whether any formatting elements needed to be reconstructed. | |||
Collaborator
There was a problem hiding this comment.
I wonder if false | int would be helpful, where we could return false or the number of reconstructed elements.
OwnerAuthor
There was a problem hiding this comment.
can you think of a case where it would be useful?
dmsnellforce-pushed
the
html-api/add-support-for-most-of-the-rest-of-the-common-tags
branch
3 times, most recently
from
January 20, 2024 00:18
89a226f to
7939dcbCompare1 task
dmsnellforce-pushed
the
html-api/improve-active-element-reconstruction
branch
from
July 2, 2024 22:33
f412732 to
55e20cfComparedmsnell
changed the base branch from
html-api/add-support-for-most-of-the-rest-of-the-common-tags
to
trunkJuly 2, 2024 22:33
19 tasks
dmsnell
commented
Jul 6, 2024
OwnerAuthor
Superseded by WordPress#6982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-61576
Adds support for active format reconstruction, which occurs when crossing certain HTML boundaries, such as when entering a new
Pelement which implicitly closed the previous one and all of the formatting elements inside it.This raises the question what to do when elements are implicitly created. This appears already with the unexpected
</p>, which creates an emptyPelement.next_tag()never finds these elements even though they appear in the breadcrumbs when moving past them.