scout hint: tell user logging in is required

[laurazard]

The docker scout quickview hint, displayed after a user pulls or builds an image, only works if the user is logged in to Hub.

What I did

Check if user is logged in, and make hint more explicit/call this requirement out if not.

Logged in (same behaviour as before):

Logged out (add message about logging in):

(not mandatory) A picture of a cute animal, if possible in relation with what you did

[laurazard]

/cc @sam-thibault@thaJeztah@dvdksn@neersighted@rumpl@vvoland (pinging y'all re: wording ideas)

[thaJeztah]

So, looking at this hint:

• logging won't be needed until I run that command
• and it's unlikely that a user will now do a docker loginif they're not planning to run the related docker scout command

I'm slightly wondering if this is "too much information" at this moment in time, and cluttering the hint (hiding away the relevant information in the noise). Effectively, this is listing prerequisites to run the docker scout command, and we should not end up with "make sure you have a working internet connection: to connect to the internet ..."

So, silly idea:

• Can we make docker scout check if the user is authenticated before the command is executed?
• Or.. make it "try", and fallback to asking the user to authenticate?
• ^^^ we should actually consider doing the same for docker pull (etc)

That would also allow us to include some of the wording we added in docker/cli#4478

Thinking of a flow like:

$ docker scout quickview hello-world
Log in with your Docker ID or email address to use the scout service. If you
don't have a Docker ID, head over to https://hub.docker.com to create one.You can log in with your password or a Personal Access Token (PAT). Usinga limited-scope PAT grants better security and is required for organizationsusing SSO. Learn more at https://docs.docker.com/go/access-tokens/Username:Password:

(we should consider changing Password to Passphrase or Passphrase or PAT, but probably should do so across the board)

[laurazard]

@eunomie thoughts on @thaJeztah's idea?

[eunomie]

I can see why we want to add more context about the docker scout commands.
To add (login required) might be OK, let me think a bit more about it. But we probably don't need the second line.

Right now, that's what you have if you run a scout command without to be logged in:

$ docker scout qv alpine:latest
ERROR Status: login using Docker Desktop or 'docker login' command: no login, Code: 1

That's not a really good user experience. However I'm not sure about the addition of the login inside docker scout.
I think the way it's working everywhere right now, is it's up to the user to login (CLI or desktop for instance).
So I don't want to include that logic here.

But to improve the login message 💯

[eunomie]

I can change the docker scout login error that way:

But I wonder if it isn't too much details for this command, as this message it's more for docker login.

[thaJeztah]

LGTM