Uh oh!
There was an error while loading. Please reload this page.
Add lua support. - #38
Conversation
yosifkit
commented
Jan 13, 2017
Very nice work. Looks like we can get Lua 5.3 from jessie-backports, so we can just swap the Debian Dockerfiles to be from |
yajo
commented
Jan 16, 2017
Cool, done |
JayH5
commented
Jan 17, 2017
On Debian you'll need |
tianon
commented
Jan 17, 2017
Yeah, there are a few other minor changes that need to be made too (whitespace, cleanup), which I've got locally in progress. 👍 Thanks @yajo! |
tianon
commented
Jan 17, 2017
... and of course, today http://www.haproxy.org decides that it should refuse our connections 😢 |
tianon
commented
Jan 17, 2017
Seems to be the same issue as in https://www.mail-archive.com/haproxy@formilux.org/msg24512.html |
ryansch
commented
Jan 17, 2017
@tianon Appears to be working now. |
…tency/maintainability (whitespace, etc)
tianon
commented
Jan 18, 2017
Rough size comparisons, for reference:
|
| && tar -xzf haproxy.tar.gz -C /usr/src/haproxy --strip-components=1 \ | ||
| && rm haproxy.tar.gz \ | ||
| && make -C /usr/src/haproxy \ | ||
| \ |
There was a problem hiding this comment.
I don't know why this (I have seen it below too a few times). Is it for adding a white line? Did you know Dockerfile's white/comment lines are ignored?
There was a problem hiding this comment.
Yes, we like to have some whitespace to separate sections of the RUN line. The Dockerfile parser does currently ignore empty lines, but it was "fixed" to not do so in moby/moby#24725 and reverted because of moby/moby#29005 in moby/moby#29064, but still planned to be deprecated with moby/moby#29161. As far as I know, comments in RUN lines will stay even if empty lines get removed.
yosifkit
commented
Jan 19, 2017
I see why it got smaller! You switched to wget and it doesn't leave behind stuff after the |
- `bash`: 4.4.7 - `golang`: 1.8rc2 - `haproxy`: add Lua support (docker-library/haproxy#38) - `postgres`: (mostly) arbitrary `--user` support (docker-library/postgres#253) - `python`: 3.4.6
Following #28 (comment), there you have Lua support for 1.6+.
It must be Lua >= 5.3, so I cannot use system packages for now. Debian and Alpine have older packaged versions.
@Tecnativa