Skip to content

Allow arbitrary --user values - #161

Merged
yosifkit merged 1 commit into
docker-library:masterfrom
infosiftr:any-user
May 13, 2016
Merged

Allow arbitrary --user values#161
yosifkit merged 1 commit into
docker-library:masterfrom
infosiftr:any-user

Conversation

@tianon

@tianontianon commented Apr 15, 2016

Copy link
Copy Markdown
Member

@tianon

tianon commented Apr 15, 2016

Copy link
Copy Markdown
MemberAuthor

According to https://www.mysql.com/support/eol-notice.html, we might technically be able to drop 5.5 as EOL as of today (although we're running it on Debian 7, which never was actually supported), but since it was pretty simple to make it work too, I just went for it.

@ltangvald

ltangvald commented Apr 17, 2016

Copy link
Copy Markdown
Collaborator

5.5 is actually pretty nice to have in that upstream doesn't actually provide Debian/Ubuntu packages for it, so I'd think the ease of use/setup of the Docker image is a pretty big plus (though I have no usage numbers to back this up with :P)

@tianon

tianon commented Apr 18, 2016 via email

Copy link
Copy Markdown
MemberAuthor

@ltangvald

ltangvald commented Apr 18, 2016

Copy link
Copy Markdown
Collaborator

Oh, and change generally looks good to me, though I have to admit I haven't looked closely at gosu :)

@tianon

tianon commented Apr 18, 2016

Copy link
Copy Markdown
MemberAuthor

It's conceptually really simple -- like sudo, but doesn't touch the TTY or stay resident, just setuid+setgid+setgroups+exec. 👍

@yosifkit

yosifkit commented Apr 19, 2016

Copy link
Copy Markdown
Member

I think the main difference is that the initdb.d scripts will no longer be run as root; not sure if that will break too many users.

@yosifkit

yosifkit commented May 12, 2016

Copy link
Copy Markdown
Member

LGTM. Should we merge?

@ltangvald

ltangvald commented May 13, 2016

Copy link
Copy Markdown
Collaborator

Yeah, I think we can.
As an aside, I forgot to consider when I made the comment about 5.5 that since it was only available on Debian6, it'll no longer be updated for any Debian/Ubuntu platform so keeping it as it is wouldn't be a good idea (issue #168).

@yosifkit
yosifkit merged commit 5296199 into docker-library:masterMay 13, 2016
@yosifkit
yosifkit deleted the any-user branch May 13, 2016 21:11
tianon added a commit to infosiftr/stackbrew that referenced this pull request May 16, 2016
@tianon
Update docker-library images
83fab5e
- `cassandra`: 3.0.6
- `mongo`: 3.3.6
- `mysql`: allow arbitrary `--user` (docker-library/mysql#161)
- `owncloud`: 8.2.5, 8.1.8, 8.0.13, 7.0.15
- `tomcat`: 9.0.0.M6, 8.5.2, 8.0.35
@tianontianon mentioned this pull request May 16, 2016
Merged
tianon added a commit to infosiftr/stackbrew that referenced this pull request May 17, 2016
@tianon
Update docker-library images
bdd0048
- `cassandra`: 3.0.6
- `mongo`: 3.3.6
- `mysql`: allow arbitrary `--user` (docker-library/mysql#161)
- `owncloud`: 8.2.5, 8.1.8, 8.0.13, 7.0.15
- `tomcat`: 9.0.0.M6, 8.5.2, 8.0.35
This was referenced May 17, 2016
Merged
Merged
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
@tianon@rscothern
Update docker-library images
6aa5547
- `cassandra`: 3.0.6
- `mongo`: 3.3.6
- `mysql`: allow arbitrary `--user` (docker-library/mysql#161)
- `owncloud`: 8.2.5, 8.1.8, 8.0.13, 7.0.15
- `tomcat`: 9.0.0.M6, 8.5.2, 8.0.35
@tianontianon mentioned this pull request Jun 16, 2016
Closed
@yosifkityosifkit mentioned this pull request Aug 22, 2016
Closed
@yosifkityosifkit mentioned this pull request Sep 2, 2016
Open
@tianontianon mentioned this pull request Dec 12, 2016
Merged
This was referenced Jan 19, 2017
Merged
Merged
@tianontianon mentioned this pull request Aug 29, 2017
Closed
This was referenced Dec 21, 2017
Merged
Closed
@tianontianon mentioned this pull request Jan 4, 2018
Closed
9 tasks
This was referenced Feb 12, 2018
Closed
Closed
@tianontianon mentioned this pull request Mar 19, 2018
Merged
@tianontianon mentioned this pull request May 18, 2018
Closed
@yosifkityosifkit mentioned this pull request Aug 13, 2018
Closed
@glenscglensc mentioned this pull request Oct 29, 2018
Closed
This was referenced Nov 1, 2018
Merged
Open
lag-linaro pushed a commit to lag-linaro/fluentd-docker-image that referenced this pull request Nov 16, 2018
Lee Jones
Do not manually fix permissions issues by manipulating /etc/passwd
3f6bae6
If permissions problems exist, they should be overcome properly.
For examples see:
LINK: docker-library/rabbitmq#60
LINK: docker-library/cassandra#48
LINK: docker-library/mongo#81
LINK: redis/docker-library-redis#48
LINK: docker-library/mysql#161
LINK: MariaDB/mariadb-docker#59
LINK: docker-library/percona#21
LINK: TryGhost/docker-library-ghost#54
LINK: docker-library/postgres#253
As suggested by @tianon
LINK: docker-library/official-images#3724 (comment)
This is part of an effort to make FluentD part of Docker's Official Images.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
lag-linaro pushed a commit to lag-linaro/fluentd-docker-image that referenced this pull request Nov 19, 2018
Lee Jones
Do not manually fix permissions issues by manipulating /etc/passwd
450a194
If permissions problems exist, they should be overcome properly.
For examples see:
LINK: docker-library/rabbitmq#60
LINK: docker-library/cassandra#48
LINK: docker-library/mongo#81
LINK: redis/docker-library-redis#48
LINK: docker-library/mysql#161
LINK: MariaDB/mariadb-docker#59
LINK: docker-library/percona#21
LINK: TryGhost/docker-library-ghost#54
LINK: docker-library/postgres#253
As suggested by @tianon
LINK: docker-library/official-images#3724 (comment)
This is part of an effort to make FluentD part of Docker's Official Images.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
lag-linaro pushed a commit to lag-linaro/fluentd-docker-image that referenced this pull request Nov 23, 2018
Lee Jones
Do not manually fix permissions issues by manipulating /etc/passwd
8859ab1
If permissions problems exist, they should be overcome properly.
For examples see:
LINK: docker-library/rabbitmq#60
LINK: docker-library/cassandra#48
LINK: docker-library/mongo#81
LINK: redis/docker-library-redis#48
LINK: docker-library/mysql#161
LINK: MariaDB/mariadb-docker#59
LINK: docker-library/percona#21
LINK: TryGhost/docker-library-ghost#54
LINK: docker-library/postgres#253
As suggested by @tianon
LINK: docker-library/official-images#3724 (comment)
This is part of an effort to make FluentD part of Docker's Official Images.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
lag-linaro pushed a commit to lag-linaro/fluentd-docker-image that referenced this pull request Nov 30, 2018
Lee Jones
Do not manually fix permissions issues by manipulating /etc/passwd
e9c1c17
If permissions problems exist, they should be overcome properly.
For examples see:
LINK: docker-library/rabbitmq#60
LINK: docker-library/cassandra#48
LINK: docker-library/mongo#81
LINK: redis/docker-library-redis#48
LINK: docker-library/mysql#161
LINK: MariaDB/mariadb-docker#59
LINK: docker-library/percona#21
LINK: TryGhost/docker-library-ghost#54
LINK: docker-library/postgres#253
As suggested by @tianon
LINK: docker-library/official-images#3724 (comment)
This is part of an effort to make FluentD part of Docker's Official Images.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
lag-linaro pushed a commit to lag-linaro/fluentd-docker-image that referenced this pull request Dec 19, 2018
Lee Jones
Do not manually fix permissions issues by manipulating /etc/passwd
34ed7d5
If permissions problems exist, they should be overcome properly.
For examples see:
LINK: docker-library/rabbitmq#60
LINK: docker-library/cassandra#48
LINK: docker-library/mongo#81
LINK: redis/docker-library-redis#48
LINK: docker-library/mysql#161
LINK: MariaDB/mariadb-docker#59
LINK: docker-library/percona#21
LINK: TryGhost/docker-library-ghost#54
LINK: docker-library/postgres#253
As suggested by @tianon
LINK: docker-library/official-images#3724 (comment)
This is part of an effort to make FluentD part of Docker's Official Images.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
@yosifkityosifkit mentioned this pull request Feb 12, 2019
Merged
@tianontianon mentioned this pull request May 17, 2019
Closed
@yosifkityosifkit mentioned this pull request Apr 6, 2021
Closed
grooverdan referenced this pull request in MariaDB/mariadb-docker Dec 6, 2021
@grooverdan
shellcheck: on entrypoint
f0c4320
Report was:
In docker-entrypoint.sh line 67:
mysql=( docker_process_sql )
^---^ SC2034: mysql appears unused. Verify use (or export if used externally).
In docker-entrypoint.sh line 81:
. "$f"
^--^ SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
In docker-entrypoint.sh line 149:
if [ -z "$MARIADB_ROOT_PASSWORD" -a -z "$MARIADB_ALLOW_EMPTY_ROOT_PASSWORD" -a -z "$MARIADB_RANDOM_ROOT_PASSWORD" ]; then
^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
In docker-entrypoint.sh line 228:
passfileArgs=()
^----------^ SC2034: passfileArgs appears unused. Verify use (or export if used externally).
In docker-entrypoint.sh line 231:
MYSQL_PWD= docker_exec_client "$@"
^-- SC1007: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
In docker-entrypoint.sh line 366:
exec gosu mysql "$BASH_SOURCE" "$@"
^----------^ SC2128: Expanding an array without an index only gives the first element.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tianon@ltangvald@yosifkit