🚑 Fix some BC break in ext install.

[shouze]

Fixes#266. Related to #256 changes.

[shouze]

nested if as its not that easy to make some XOR in shell scripts.

[ktogo]

Looks good to me thanks @shouze !

[yosifkit]

This will break our detection of the php source being already extracted on line 22

Also, this is somehow spaces instead of tabs.

[shouze]

Indeed, will fix that

[yosifkit]

❤️ Thanks

[shouze]

ping @yosifkit ok, amended fixes in the commit.

[shouze]

I just don't check that ext is a directory here... but I think we shouldn't care because people in this case would intentionally make their builds fail I guess ^^

[yosifkit]

I don't feel like this is a complete solution. Seeing that many users were using ext-install in an unexpected way makes me realize that this current fix will only break a different set of users. We need to only delete folders from /usr/src/php/ext/ that are part of the tar file. They could be doing something like the following:

RUN git clone https://github.com/php-memcached-dev/php-memcached /usr/src/php/ext/memcached \
&& cd /usr/src/php/ext/memcached && git checkout -b php7 origin/php7 \
&& docker-php-ext-install zip \
# at which point their memcached source is now gone
&& docker-php-ext-configure memcached \
&& docker-php-ext-install memcached

Or we could do as @tianon suggested and revert the change on the regular Debian images. I am leaning toward this idea right now

[shouze]

@yosifkit yes good catch indeed. Anyway we should return a clear error message as suggested in #268. Then taking the decision to revert or no for debian.

[ktogo]

@yosifkit ping #269 (comment)

[ktogo]

@yosifkit@shouze Do you have any update on this?