Add additional modules to include

[daghack]

Add in support for the gd, curl, and gzip php modules.

[tianon]

+1, but can you add it to all the other versions too? 😉

[thaJeztah]

Should --with-mysql still be included? The mysql extension is deprecated as of PHP 5.5; http://php.net/manual/en/intro.mysql.php

Maybe only keep it in the PHP5.4 image?

[daghack]

Oh, yes, silly me. One of these days, I'll get on of these PR's accepted without you having issues with it, if it's the last thing I do, tianon ;P

As far as --with-mysql being included, you may be correct, but that's not something this PR was meant to address. IMO, that should be put as a separate issue, rather than an issue with this particular PR.

[tianon]

Yeah, I'm still +1 on keeping --with-mysql, but definitely agree it should be a separate PR to discuss that (as that's completely unrelated to this one).

[thaJeztah]

should be put as a separate issue, rather than an issue with this particular PR

+1 I just noticed that it was still there and thought it would be an easy fix while you were editing those files. I'm not behind my computer ATM so not able to create a PR.

[daghack]

I updated to include the other versions.

Additionally, I opened issue #28 so that we can move the discussion of the --with-mysql flag away from here.

[tianon]

LGTM; did you build test all three? :)

[daghack]

That I did.

[tianon]

👍

cc @yosifkit

[thaJeztah]

Thanks @Moghedrin!

[thaJeztah]

@Moghedrin I noticed you didn't update the apache versions; I know there's an update.sh script that handles this, but should PRs update both the regular and the apache versions? (not sure)

[yosifkit]

Good point @thaJeztah. @Moghedrin can you run the update.sh to get the apache versions too?

[thaJeztah]

Slightly related; the update.sh script doesn't work on OS X 10.9.5. It gives an "invalid argument" error. Probably something with awk versions or so, but I didn't look into it properly yet. On Ubuntu it worked correctly.

[yosifkit]

That would be the readlink -f. OS X does not have the same GNU readlink.

[thaJeztah]

Could be yes; do you want me to look into it? Or just leave it as a "known issue". Manually updating the Dockerfiles isn't too much hassle right now.

[yosifkit]

It will be a problem in all the Official Images scripts (since readlink -f is such a nice feature and is a known problem in OS X), "known issue" is fine for now.

[daghack]

Silly me. I've updated the apache versions as well :)

[yosifkit]

LGTM

[tianon]

LGTM

[thaJeztah]

👍

[md5]

Looks like --with-gzip should have been --with-zlib:

configure: WARNING: unrecognized options: --with-gzip