Skip to content

Remove unnecessary ruby-libs package#131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
y3ti wants to merge 1 commit into from
Closed

Remove unnecessary ruby-libs package #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 2.1/alpine/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,6 +78,7 @@ RUN set -ex \
scanelf --needed --nobanner --recursive /usr/local \
| awk '{ gsub(/,/, "\nso:", $2); print "so:" $2 }' \

@tianontianonJun 5, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's this bit that causes the trouble -- we only know that we're linked against libruby.so.2.3, not the full path to the proper .so file. 😞

$ docker run -it --rm ruby:2.3-alpine sh/ # scanelf --needed --nobanner --recursive /usr/local | awk '{ gsub(/,/, "\nso:", $2); print "so:" $2 }' | sort -uso:libc.musl-x86_64.so.1so:libcrypto.so.1.0.0so:libffi.so.6so:libgdbm.so.4so:libgdbm_compat.so.4so:libncursesw.so.6so:libreadline.so.6so:libruby.so.2.3so:libssl.so.1.0.0so:libyaml-0.so.2so:libz.so.1/ #

@y3tiy3tiJun 5, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and we have two libruby.so installed.

grep -v libruby removes ruby-libs from dependencies list. My solution is only a workaround and I would like to point at the issue.

@yosifkityosifkitJun 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the bug, but I would like to find a general solution to apply it to images other than ruby. Many official images that build from source on alpine use these same scanelf lines and might be have a similar problem.

🤔 😢

| sort -u \
| grep -v libruby \
| xargs -r apk info --installed \
| sort -u \
)" \
Expand Down
1 change: 1 addition & 0 deletions 2.2/alpine/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,6 +78,7 @@ RUN set -ex \
scanelf --needed --nobanner --recursive /usr/local \
| awk '{ gsub(/,/, "\nso:", $2); print "so:" $2 }' \
| sort -u \
| grep -v libruby \
| xargs -r apk info --installed \
| sort -u \
)" \
Expand Down
1 change: 1 addition & 0 deletions 2.3/alpine/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,6 +78,7 @@ RUN set -ex \
scanelf --needed --nobanner --recursive /usr/local \
| awk '{ gsub(/,/, "\nso:", $2); print "so:" $2 }' \
| sort -u \
| grep -v libruby \
| xargs -r apk info --installed \
| sort -u \
)" \
Expand Down
1 change: 1 addition & 0 deletions 2.4/alpine/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,6 +78,7 @@ RUN set -ex \
scanelf --needed --nobanner --recursive /usr/local \
| awk '{ gsub(/,/, "\nso:", $2); print "so:" $2 }' \
| sort -u \
| grep -v libruby \
| xargs -r apk info --installed \
| sort -u \
)" \
Expand Down
1 change: 1 addition & 0 deletions Dockerfile-alpine.template
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,6 +78,7 @@ RUN set -ex \
scanelf --needed --nobanner --recursive /usr/local \
| awk '{ gsub(/,/, "\nso:", $2); print "so:" $2 }' \
| sort -u \
| grep -v libruby \
| xargs -r apk info --installed \
| sort -u \
)" \
Expand Down