Skip to content

Add debian:bookworm - #415

Merged
tianon merged 1 commit into
docker-library:masterfrom
sitano:ivan_ruby_bookworm
Jun 13, 2023
Merged

Add debian:bookworm#415
tianon merged 1 commit into
docker-library:masterfrom
sitano:ivan_ruby_bookworm

Conversation

@sitano

@sitanositano commented Apr 5, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

bookworm distro for different Ruby versions + 2.7.8 support

@tianon

tianon commented Apr 5, 2023

Copy link
Copy Markdown
Member

See also docker-library/golang#456 (comment)

@ojab

ojab commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Bump since it was released https://www.debian.org/News/2023/20230610

ojab
ojab reviewed Jun 13, 2023
View reviewed changes
Comment threadversions.json Outdated
Comment on lines 9 to 10
"buster",
"slim-buster",

@ojabojabJun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess buster should be removed per #357 (comment)

@sitanositanoJun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojab should I remove buster lines though?

@sitano
sitanoforce-pushed the ivan_ruby_bookworm branch from fb0c730 to 49f2919CompareJune 13, 2023 15:56
@sitano

sitano commented Jun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

I have rebased the branch to fix conflicts.
At the moment it does not compile with apline17 and 18 due to openssl version iirc, but not remember for sure.
update.sh breaks versions.json for 2.7, I am not sure if I need to fix this script and what it does at all.

@ojab

ojab commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

I believe the single change should be

diff --git a/versions.sh b/versions.sh
index 0901026..6848b79 100755
--- a/versions.sh+++ b/versions.sh@@ -70,8 +70,8 @@ for version in "${versions[@]}"; do
sha256: env.shaVal,
variants: [
(
+ "bookworm",
"bullseye",
- "buster",
empty # trailing comma hack
| ., "slim-" + .), # https://github.com/docker-library/ruby/pull/142#issuecomment-320012893
(

and everything else should be autogenerated by ./update.sh (don't see any special cases for buster, so nothing else to remove + dunno why need_openssl flag is needed).

(NB: I'm not a maintainer)

@ojab

ojab commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Ah, missed + 2.7.8 support part. Also shouldn't be here, it's EOLed/unsupported and was dropped because of that.

@yosifkit
yosifkitforce-pushed the ivan_ruby_bookworm branch from 49f2919 to 359f11fCompareJune 13, 2023 17:50
@yosifkit

yosifkit commented Jun 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Force pushed to drop out Ruby 2.7 and buster; also added same fix as docker-library/python#822 (comment).

Edit: kept buster for Ruby 3.0 since it doesn't support OpenSSL 3.

@yosifkit
yosifkitforce-pushed the ivan_ruby_bookworm branch from 359f11f to 2d74dd0CompareJune 13, 2023 18:06
@sitano@yosifkit
Add debian:bookworm, drop buster
ed1be47
Signed-off-by: Ivan Prisyazhnyy <john.koepi@gmail.com>
@yosifkit
yosifkitforce-pushed the ivan_ruby_bookworm branch from 2d74dd0 to ed1be47CompareJune 13, 2023 18:08
@tianon
tianon merged commit 65c8de9 into docker-library:masterJun 13, 2023
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 13, 2023
@docker-library-bot
Update ruby
ee693b5
Changes:
- docker-library/ruby@65c8de9: Merge pull request docker-library/ruby#415 from sitano/ivan_ruby_bookworm
- docker-library/ruby@ed1be47: Add debian:bookworm, drop buster
@sitano
sitano deleted the ivan_ruby_bookworm branch June 14, 2023 10:43
@sitano

sitano commented Jun 14, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thank you for accepting this PR!
You would be surprised how many people still sit on 2.7.x.

@tianontianon mentioned this pull request Jun 14, 2023
Merged
@yahondayahonda mentioned this pull request Jun 15, 2023
Closed
yahonda added a commit to yahonda/buildkite-config that referenced this pull request Jun 15, 2023
@yahonda
Use Debian 11 "bullseye" based Ruby Docker image
be78b6e
This commit changes Ruby Docker images for 3.1 and 3.2
from Debian 12 "bookworm" based to Debian 11 "bullseye".
Until we address the root cause of rails/rails#48483
Refer to docker-library/ruby#415
@yahondayahonda mentioned this pull request Jun 15, 2023
Merged
generalmimon added a commit to kaitai-io/kaitai_struct_visualizer that referenced this pull request Jul 23, 2023
@generalmimon
Dockerfile: use OpenJDK 17 and Ruby 3.2
47721ce
The base `ruby` image dropped Debian 10 ("buster") images and converted
them to Debian 12 ("bookworm") - see
<docker-library/ruby#415>. However, while
OpenJDK 11 was available in "buster", it is no longer available in
"bookworm", so we now have to use OpenJDK 17 instead.
@yosifkityosifkit mentioned this pull request Jan 2, 2024
Closed
@yosifkityosifkit mentioned this pull request Aug 13, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ojabojabojab left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sitano@tianon@ojab@yosifkit