Adjust "wp-config.php" behavior to be skipped if configuration is not provided

[tianon]

Also, unset "secret" environment variables before starting Apache/FPM to ensure that a stray phpinfo() doesn't include secrets from our code. (cc @thaJeztah)

Fixes#135

It's worth noting that WordPress now will also detect the absence of wp-config.php, and have a short pre-wizard to configure it, so all configuration can be done directly in the browser (which this PR enables by skipping the wp-config.php behavior if we don't have one of the special WORDPRESS_... vars, or an explicitly linked mysql container sharing environment variables with us).

[tianon]

It doesn't help a ton, but it is easier to review at https://github.com/docker-library/wordpress/pull/206/files?w=1 (ignoring whitespace)

[tianon]

Of course, it fails because wp-config.php is actually more than just a simple configuration file.......

I'll probably just scrape the variables we need directly from the environment instead in that bit of the script (which is still better than taking them in $argv to that php process).

[tianon]

Yay 🍏

[Spittal]

Hey this is still an issue for me. Using the any tagged official wordpress image. But, my preferred tag is 7.1-fpm

Here's the docker-compose.yml

 wordpress:
image: wordpress
volumes:
- ./wp-theme:/var/www/html/wp-content/themes/springboardvr
- ./wp-config.php:/var/www/html/wp-config.php
ports:
- 8081:80
environment:
- WORDPRESS_DB_HOST=
- WORDPRESS_DB_USER=
- WORDPRESS_DB_PASSWORD=
- WORDPRESS_DB_NAME=

I fail with the error:
wordpress_1 | sed: cannot rename ./sedGAfbPd: Resource busy

The image works if I comment out the line
- ./wp-config.php:/var/www/html/wp-config.php

[yosifkit]

It'll only skip setting config values in wp-config.php if you don't supply any of the environment variables, since you can just put them in the config if you are supplying it. The reason for the failing is probably because sed creates a new temporary file to save edits to and then tries to rename it on top of the wp-config.php file you bind-mounted in, which is not possible.

[Spittal]

Oh I see, thanks for the information.