Skip to content

Change permissions handling to be more conservative - #74

Merged
tianon merged 1 commit into
docker-library:masterfrom
infosiftr:conservative-permissions
Apr 21, 2015
Merged

Change permissions handling to be more conservative#74
tianon merged 1 commit into
docker-library:masterfrom
infosiftr:conservative-permissions

Conversation

@tianon

Copy link
Copy Markdown
Member

This allows things like bind-mounting into /var/www/html/wp-content/themes/example and not clobbering host permissions, making theme development and testing much simpler (change PHP file on host, reload page, etc).

This allows things like bind-mounting into `/var/www/html/wp-content/themes/example` and not clobbering host permissions, making theme development and testing much simpler (change PHP file on host, reload page, etc).
@tianon

Copy link
Copy Markdown
MemberAuthor

Essentially, we chown the content we copy from instead of the copied content, so when the files get copied in they already have the correct permissions. Then we just have to clean up files we create afterwards which will be root:root.

@yosifkit

Copy link
Copy Markdown
Member

LGTM

@yosifkit

Copy link
Copy Markdown
Member

Needs docs 😉

@tianon

Copy link
Copy Markdown
MemberAuthor

Yeah.... Shhh 😉

tianon added a commit that referenced this pull request Apr 21, 2015
Change permissions handling to be more conservative
@tianon
tianon merged commit f5e1554 into docker-library:masterApr 21, 2015
@tianon
tianon deleted the conservative-permissions branch April 21, 2015 21:40
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 21, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tianon@yosifkit