Skip to content

buildx(install): use sigstore module to verify signature - #929

Merged
crazy-max merged 3 commits into
docker:mainfrom
crazy-max:buildx-verify
Jan 29, 2026
Merged

buildx(install): use sigstore module to verify signature#929
crazy-max merged 3 commits into
docker:mainfrom
crazy-max:buildx-verify

Conversation

@crazy-max

Copy link
Copy Markdown
Member

Comment threadsrc/buildx/install.ts Outdated
const signedEntity = toSignedEntity(bundle, fs.readFileSync(binPath));
const verifier = new Verifier(trustMaterial);
const signer = verifier.verify(signedEntity, {
subjectAlternativeName: /^https:\/\/github\.com\/docker\/(github-builder-experimental|github-builder)\/\.github\/workflows\/build\.yml.*$/,

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regexp not supported like cosign:

'--certificate-identity-regexp',opts.certificateIdentityRegexp

Opened sigstore/sigstore-js#1556

@crazy-maxcrazy-max mentioned this pull request Jan 12, 2026
27 tasks
@crazy-max
crazy-maxforce-pushed the buildx-verify branch 13 times, most recently from 13330f9 to 01bd355CompareJanuary 15, 2026 09:29
@crazy-max
crazy-max marked this pull request as ready for review January 15, 2026 09:35
Comment thread__tests__/buildx/install.test.itg.ts Outdated
maybe('download', () => {
// prettier-ignore
test.each(['latest'])(
test.each(['v0.31.0-rc1'])(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove rc?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes let me change that

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
crazy-max merged commit cf27b74 into docker:mainJan 29, 2026
204 of 206 checks passed
@crazy-max
crazy-max deleted the buildx-verify branch January 29, 2026 15:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@crazy-max@tonistiigi