Skip to content

ls: move builder/node status error msg below table - #1109

Merged
tonistiigi merged 1 commit into
docker:masterfrom
crazy-max:ls-progress
Jun 14, 2022
Merged

ls: move builder/node status error msg below table#1109
tonistiigi merged 1 commit into
docker:masterfrom
crazy-max:ls-progress

Conversation

@crazy-max

Copy link
Copy Markdown
Member

follow-up #830

as suggested in #764, display builder/node status error msg below table to avoid a messy output:

$ docker buildx ls
NAME/NODE DRIVER/ENDPOINT STATUS BUILDKIT PLATFORMS
builder * docker-container
builder0 unix:///var/run/docker.sock running b6924b0 linux/amd64, linux/arm64, linux/riscv64
mac-mini-m1 tcp://mac-mini-m1.home.com:2376 running b6924b0 linux/arm64*, linux/amd64
sifive tcp://sifive.home.com:2375 running b6924b0 linux/riscv64*
builder2 docker-container
builder20 unix:///var/run/docker.sock inactive
graviton2 docker-container
node1 ssh://ubuntu@18.216.87.142 Get "http://docker.example.com/v1.24/info": context deadline exceeded
desktop-linux protocol not available
desktop-windows protocol not available
default docker
default default running 20.10.14 linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6

now:

$ docker buildx ls
NAME/NODE DRIVER/ENDPOINT STATUS BUILDKIT PLATFORMS
builder * docker-container
builder0 unix:///var/run/docker.sock running b6924b0 linux/amd64, linux/arm64, linux/riscv64
mac-mini-m1 tcp://mac-mini-m1.home.com:2376 running b6924b0 linux/arm64*, linux/amd64
sifive tcp://sifive.home.com:2375 running b6924b0 linux/riscv64*
builder2 docker-container
builder20 unix:///var/run/docker.sock inactive
graviton2 docker-container
node1 ssh://ubuntu@18.216.87.142 error
desktop-linux error
desktop-windows error
default docker
default default running 20.10.14 linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
Failed to get status for graviton2 (node1): Get "http://docker.example.com/v1.24/info": context deadline exceeded
Cannot load builder desktop-linux: protocol not available
Cannot load builder desktop-windows: protocol not available

will take a look for a progress tabwriter in a follow-up

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Comment threadcommands/ls.go Outdated
@crazy-max
crazy-maxforce-pushed the ls-progress branch 2 times, most recently from 1b2b2cc to 79a7deeCompareMay 14, 2022 17:17
@crazy-max
crazy-max requested a review from tonistiigiMay 24, 2022 12:08
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-maxcrazy-max added this to the v0.9.0 milestone Jun 7, 2022
@tonistiigi
tonistiigi merged commit 0295555 into docker:masterJun 14, 2022
@crazy-max
crazy-max deleted the ls-progress branch June 14, 2022 17:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@crazy-max@tonistiigi